Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS support for multiple HIP SDK versions #203

Open
wants to merge 10 commits into
base: amd-staging
Choose a base branch
from
Open

VS support for multiple HIP SDK versions #203

wants to merge 10 commits into from

Conversation

schung-amd
Copy link
Contributor

  • Add HIP SDK version detection to .vcxproj files via HIP_PATH environment variable and associated .hipVersion file
  • Import the appropriate toolset properties and targets as default
  • Import additional toolset properties and targets to prevent property page in VS from breaking when another toolset is selected
  • Add build exclusion for toolsets which do not match the detected HIP SDK version
  • Adds associated documentation to the README providing guidance on how to use the VS files when multiple HIP SDK versions are installed

@schung-amd schung-amd requested review from a team and dgaliffiAMD as code owners February 26, 2025 22:51
@schung-amd
Copy link
Contributor Author

Removed hardcoded additional toolset imports as original code works here (detecting HIPVersion by stripping from the selected platform toolset name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohaibnd sohaibnd sohaibnd approved these changes

@dgaliffiAMD dgaliffiAMD Awaiting requested review from dgaliffiAMD dgaliffiAMD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schung-amd @sohaibnd